[HUDI-2872][HUDI-2646] Refactoring layout optimization (clustering) flow to support linear ordering #4606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@alexeykudinkin : is there anyone you know will review this patch or you want me to review. |
Contributor
|
btw, looks like there are some CI failures. can you please check them. |
added 14 commits
January 19, 2022 14:33
…curve partitioner as well
Deprecated superfluous settings
`TestSpaceCurveLayoutOptimization` > `TestLayoutOptimization`
…composition methods
Tidying up configs
nsivabalan
reviewed
Jan 20, 2022
Contributor
nsivabalan
left a comment
nsivabalan
left a comment
There was a problem hiding this comment.
LGTM in general. one clarification. We are not changing any config names right? I did verify, but just wanted to confirm. if yes, might have to add older config as alternative.
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java
Show resolved
Hide resolved
...n/java/org/apache/hudi/client/clustering/run/strategy/MultipleSparkJobExecutionStrategy.java
Show resolved
Hide resolved
Contributor
Author
|
@nsivabalan correct, all configs are kept and marked as deprecated. The only thing that changes is that some of them have actually no effect anymore. How should we handle this? For example
|
alexeykudinkin
force-pushed
the
ak/clstr-ref-1
branch
from
80899c4 to
a0b32bb
Compare
nsivabalan
reviewed
Jan 21, 2022
| * The more columns involved in sorting, the worse the aggregation, and the smaller the query performance improvement. | ||
| * Choose the filter columns which commonly used in query sql as sort columns. | ||
| * It is recommend that 2 ~ 4 columns participate in sorting. | ||
| * @deprecated this setting has no effect |
Contributor
There was a problem hiding this comment.
can you add in documentation as to what other config(s) the user is supposed to look into instead of this deprecated one.
nsivabalan
approved these changes
Jan 21, 2022
Contributor
nsivabalan
left a comment
nsivabalan
left a comment
There was a problem hiding this comment.
LGTM. one nit on documentation about deprecating configs
Elaborated what configs users should refer to instead
Contributor
|
@alexeykudinkin : I pushed a minor update to fix the build failure. |
Collaborator
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Jan 25, 2022
…low to support linear ordering (apache#4606) Refactoring layout optimization (clustering) flow to - Enable support for linear (lexicographic) ordering as one of the ordering strategies (along w/ Z-order, Hilbert) - Reconcile Layout Optimization and Clustering configuration to be more congruent
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Jan 26, 2022
…low to support linear ordering (apache#4606) Refactoring layout optimization (clustering) flow to - Enable support for linear (lexicographic) ordering as one of the ordering strategies (along w/ Z-order, Hilbert) - Reconcile Layout Optimization and Clustering configuration to be more congruent
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
…low to support linear ordering (apache#4606) Refactoring layout optimization (clustering) flow to - Enable support for linear (lexicographic) ordering as one of the ordering strategies (along w/ Z-order, Hilbert) - Reconcile Layout Optimization and Clustering configuration to be more congruent
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
…low to support linear ordering (apache#4606) Refactoring layout optimization (clustering) flow to - Enable support for linear (lexicographic) ordering as one of the ordering strategies (along w/ Z-order, Hilbert) - Reconcile Layout Optimization and Clustering configuration to be more congruent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
Refactoring layout optimization (clustering) flow to
Brief change log
Verify this pull request
This pull request is already covered by existing tests, such as (please describe tests).
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.